Exclude unnecessary sqlite assemblies for .Net 6 host#57977
Merged
JoeRobich merged 1 commit intodotnet:mainfrom Dec 1, 2021
Merged
Exclude unnecessary sqlite assemblies for .Net 6 host#57977JoeRobich merged 1 commit intodotnet:mainfrom
JoeRobich merged 1 commit intodotnet:mainfrom
Conversation
CyrusNajmabadi
approved these changes
Nov 29, 2021
Comment on lines
+23
to
+24
| <!-- the only assembly we need under runtime folder (runtimes\win-x64\native\e_sqlite3.dll) is handled by the vsix project directly --> | ||
| <_ExcludedFiles Include="$(PublishDir)\runtimes\**\*.*" /> |
Member
There was a problem hiding this comment.
Is this going to cause any surprises down the road if somebody is trying to add something else and this breaks it?
Member
Author
There was a problem hiding this comment.
I agree this is fragile (so does the way we pick and drop the sqlite dll in the roslyn vsix project.) I'm hoping that our integration test would catch it with newly added debug.assert
Member
|
The failing unit test is a known flaky test - #34207 Since the Helix run of the Linux Debug tests passed, this is low risk to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required file is handled by the vsix project directly (see #57836)