Merged
Conversation
dibarbet
approved these changes
Nov 16, 2021
ryzngard
approved these changes
Nov 16, 2021
This was referenced Nov 16, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by TS/JS. Their project system spins up asynchronously and so there can be time periods when .js files are both known to have the right content type, but there is no doc available for them yet. This was causing a null to propagate through non-NRT annotated code, eventually crashing things. I have fixed the issue and manually tested the JS scenario.
View with whitspace off.