Ensure that getting the checksum for a project cone is resilient to its project references being missing#57776
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Nov 16, 2021
Conversation
…ts project references being missing
ryzngard
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1436227
Comment in code explains the scenario. But effectively it is part of our underlying green project tree that it can represent links between states that are stale and refer to states the current green state doesn't contain. The red layer on top already ensures the right state is shown to any consumer from that layer, however we have code what was walking the green state and crashed here.
I don't love that the green layer can be in a place like this, but it's been part of the nature of this system for a while.