Mitigate the GeneratorDriver missync issue while capturing dumps#57680
Merged
jasonmalinowski merged 2 commits intodotnet:release/dev17.0-vs-depsfrom Nov 11, 2021
Merged
Conversation
ryzngard
reviewed
Nov 10, 2021
ryzngard
reviewed
Nov 10, 2021
3acf384 to
f2b7597
Compare
AbhitejJohn
reviewed
Nov 10, 2021
jasonmalinowski
commented
Nov 10, 2021
| { | ||
| // record NFW to see who violates contract. | ||
| WatsonReporter.ReportNonFatal(new Exception("errorId is null")); | ||
| FatalError.ReportAndCatch(new Exception("errorId is null")); |
Member
Author
There was a problem hiding this comment.
Since I had to touch this, trying to make everything consistently go through FatalError* as opposed to something else.
CyrusNajmabadi
approved these changes
Nov 10, 2021
ryzngard
approved these changes
Nov 10, 2021
f2b7597 to
3652637
Compare
333fred
approved these changes
Nov 10, 2021
jaredpar
approved these changes
Nov 10, 2021
src/VisualStudio/Core/Def/Implementation/Watson/WatsonReporter.cs
Outdated
Show resolved
Hide resolved
This mitigates https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1423058 which is happening because somehow our tracked project state is getting out of sync with our GeneratorDriver; when we're transforming GeneratorDrivers we already have a mechanism to throw out the driver and simply re-create it later; that's not ideal from a performance perspective but it's better than throwing exceptions and breaking features. This will also force dumps to be created in this situation, even if that's something not being requested via the telemetry service. Since we've discovered that the telemetry service won't correctly let us request dumps for out-of-process work.
3652637 to
85c74d3
Compare
Since we are using reflection to copy this value around, we can't use a custom delegate type that won't unify across assemblies. This makes us use Action<T1, T2> instead, and I just comment out the support for non-fatal reporting in the result provider, since we don't actually use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mitigates https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1423058 which is happening because somehow our tracked project state is getting out of sync with our GeneratorDriver; when we're transforming GeneratorDrivers we already have a mechanism to throw out the driver and simply re-create it later; that's not ideal from a performance perspective but it's better than throwing exceptions and breaking features.
This will also force dumps to be created in this situation, even if that's something not being requested via the telemetry service. Since we've discovered that the telemetry service won't correctly let us request dumps for out-of-process work.