Skip to content

Don't suggest simplification for positional patterns#57676

Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
svick:dont-simplify-positional-pattern
Nov 10, 2021
Merged

Don't suggest simplification for positional patterns#57676
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
svick:dont-simplify-positional-pattern

Conversation

@svick
Copy link
Member

@svick svick commented Nov 10, 2021

Fixes #57674.

As the name implies, extended property patterns are not available in positional patterns, so the analyzer should not suggest them there.

@svick svick requested a review from a team as a code owner November 10, 2021 14:23
@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE labels Nov 10, 2021
@svick svick force-pushed the dont-simplify-positional-pattern branch from 2c334f6 to 1bd3c56 Compare November 10, 2021 15:52
@CyrusNajmabadi CyrusNajmabadi merged commit 96aaaef into dotnet:main Nov 10, 2021
@ghost ghost added this to the Next milestone Nov 10, 2021
@svick svick deleted the dont-simplify-positional-pattern branch November 10, 2021 19:31
@allisonchou allisonchou modified the milestones: Next, 17.1.P2 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IDE0170 should be disabled on the positional pattern with property pattern as the nested one

4 participants