Don't throw when delay is expedited in tests#57631
Merged
genlu merged 2 commits intodotnet:mainfrom Nov 10, 2021
Merged
Conversation
sharwell
reviewed
Nov 8, 2021
src/Workspaces/Core/Portable/Shared/TestHooks/AsynchronousOperationListener.cs
Outdated
Show resolved
Hide resolved
| /// <summary> | ||
| /// An awaitable that wraps a task and never throws an exception when waited on. | ||
| /// </summary> | ||
| public readonly struct NoThrowTaskAwaitable |
Member
Author
There was a problem hiding this comment.
I think it might be better to keep copied code together? But I'm fine either way.
Contributor
There was a problem hiding this comment.
if you prefer that, then that's fine :)
Member
Author
|
@sharwell this is ready for review. Please take another look, thanks! |
sharwell
approved these changes
Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce the number of first chance exceptions in tests, which make it easier for existing tools to detect regression in number of exceptions thrown during tests.
For example, this change eliminated 7,000+ TaskCancelledException in the typing RPS test.