Skip to content

Compare arrow expression clauses when they are children of properties or indexers#57624

Merged
davidwengier merged 1 commit intodotnet:mainfrom
davidwengier:ExpressionBodiedActiveStatementsFix
Nov 9, 2021
Merged

Compare arrow expression clauses when they are children of properties or indexers#57624
davidwengier merged 1 commit intodotnet:mainfrom
davidwengier:ExpressionBodiedActiveStatementsFix

Conversation

@davidwengier
Copy link
Member

@davidwengier davidwengier commented Nov 8, 2021

Fixes AB#1431181

TryFindMemberDeclaration returns ArrowExpressionClauses for expression bodied properties and indexers here: https://github.com/dotnet/roslyn/pull/53735/files#diff-d27a49a9c0c463968b650ddaefd03c039ed33d7b9ead3d9d82b58ae051df585cR131-R136

As these weren't in the syntax tree edit matches various contracts failed when active statements come from them.

@davidwengier davidwengier requested a review from tmat November 8, 2021 03:14
@davidwengier davidwengier requested a review from a team as a code owner November 8, 2021 03:14
@ghost
Copy link

ghost commented Nov 8, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier merged commit 8cfddbf into dotnet:main Nov 9, 2021
@davidwengier davidwengier deleted the ExpressionBodiedActiveStatementsFix branch November 9, 2021 23:05
@ghost ghost added this to the Next milestone Nov 9, 2021
@allisonchou allisonchou modified the milestones: Next, 17.1.P2 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants