reduce number of test legs we have to match a pairwise test approach#57586
Merged
jmarolf merged 5 commits intodotnet:mainfrom Dec 10, 2021
Merged
reduce number of test legs we have to match a pairwise test approach#57586jmarolf merged 5 commits intodotnet:mainfrom
jmarolf merged 5 commits intodotnet:mainfrom
Conversation
a83a662 to
9860626
Compare
RikkiGibson
reviewed
Nov 5, 2021
RikkiGibson
reviewed
Nov 9, 2021
| testArtifactName: Transport_Artifacts_Windows_Release | ||
| configuration: Release | ||
| testArguments: -testDesktop -test64 | ||
| testArguments: -testDesktop -test64 -helixQueueName Windows.10.Amd64.Server19H1.ES.Open |
Member
There was a problem hiding this comment.
I imagine this is to complement the fact that we don't run Test Windows Desktop Release 64 on PRs?
RikkiGibson
approved these changes
Nov 9, 2021
Member
RikkiGibson
left a comment
There was a problem hiding this comment.
LGTM, I would just ask that we also try doing a manual branch build of roslyn-ci to demonstrate that the extra jobs run on the rolling build. Will probably be necessary to push the branch to dotnet/roslyn.
Contributor
Author
|
@RikkiGibson queued CI build here. Appears to have the additional runs that we want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using the pict model from here we should be able to reduce the number of tests we are running while getting the same coverage.