proposed document pull diagnostics implementation#57518
Merged
dibarbet merged 9 commits intodotnet:mainfrom Nov 9, 2021
Merged
proposed document pull diagnostics implementation#57518dibarbet merged 9 commits intodotnet:mainfrom
dibarbet merged 9 commits intodotnet:mainfrom
Conversation
| { | ||
| return new DefaultAnalyzerAssemblyLoader(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
could we put this stuff in a separate PR?
| // we're passing in. If information is already cached for that snapshot, it will be returned. Otherwise, | ||
| // it will be computed on demand. Because it is always accurate as per this snapshot, all spans are correct | ||
| // and do not need to be adjusted. | ||
| return _analyzerService.GetDiagnosticsForSpanAsync(document, range: null, cancellationToken: cancellationToken); |
Contributor
There was a problem hiding this comment.
note for future LSP meetings. It's a shame we can't benefit from the range bit. it woudl be nice if the client only cared about what was in view and scoped down to that.
CyrusNajmabadi
approved these changes
Nov 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO -