Switch to 1ES servicing pools on release/dev16.11-vs-deps#57482
Merged
JoeRobich merged 8 commits intodotnet:release/dev16.11-vs-depsfrom Dec 2, 2021
Merged
Switch to 1ES servicing pools on release/dev16.11-vs-deps#57482JoeRobich merged 8 commits intodotnet:release/dev16.11-vs-depsfrom
JoeRobich merged 8 commits intodotnet:release/dev16.11-vs-depsfrom
Conversation
Member
|
@jonfortescue Would probably be fine moving off the VS2019.Pre images for integration tests. |
Contributor
Author
|
@JoeRobich okay sweet! Will do that. |
Contributor
Author
|
a |
JoeRobich
reviewed
Nov 1, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
@JoeRobich looks like lsp is failing because of VS2022, probably. Should we switch to 2019? |
JoeRobich
reviewed
Dec 2, 2021
Member
|
Yeah I agree. The dev16.x integration tests should target VS 2019. |
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Contributor
Author
|
@JoeRobich looks like this just has a macOS failure (we didn't change the macOS agents) and a random test failure in one leg of the integration tests (unlikely to be agent-related, I think). What are your thoughts on merging this as is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://github.com/dotnet/core-eng/issues/14276.