Switch to calling into IAsyncLightBulbSession directly to avoid polling.#57316
Merged
CyrusNajmabadi merged 6 commits intodotnet:mainfrom Oct 28, 2021
Merged
Switch to calling into IAsyncLightBulbSession directly to avoid polling.#57316CyrusNajmabadi merged 6 commits intodotnet:mainfrom
CyrusNajmabadi merged 6 commits intodotnet:mainfrom
Conversation
sharwell
reviewed
Oct 21, 2021
src/VisualStudio/IntegrationTest/TestUtilities/LightBulbHelper.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Oct 21, 2021
This was referenced Oct 22, 2021
sharwell
approved these changes
Oct 26, 2021
sharwell
reviewed
Oct 26, 2021
Comment on lines
-58
to
-59
| if (status is not QuerySuggestedActionCompletionStatus.Completed and | ||
| not QuerySuggestedActionCompletionStatus.Canceled) |
Contributor
There was a problem hiding this comment.
📝 This (the old code) is completely broken, leading to issues like #57326. TryGetSuggestedActionSets ignores pending asynchronous requests and returns Completed instead of returning the aggregate status InProgress.
jmarolf
approved these changes
Oct 26, 2021
ryzngard
approved these changes
Oct 26, 2021
512273a to
9074f1b
Compare
sharwell
reviewed
Oct 27, 2021
| return true; | ||
|
|
||
| await suggestedAction.GetTestAccessor().InvokeAsync(); | ||
| broker.DismissSession(view); |
Contributor
There was a problem hiding this comment.
📝 This is the key difference. We explicitly dismiss the light bulb session before invoking the action from it.
sharwell
reviewed
Oct 27, 2021
|
|
||
| const VSConstants.VSStd2KCmdID ECMD_SMARTTASKS = (VSConstants.VSStd2KCmdID)147; | ||
| var cmdID = ECMD_SMARTTASKS; | ||
| var cmdID = VSConstants.VSStd14CmdID.ShowQuickFixes; |
Contributor
There was a problem hiding this comment.
📝 This is the action bound to Ctrl+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57321
Fixes #57326