Don't compute the information for the code definition window if not open#57307
Merged
jasonmalinowski merged 1 commit intodotnet:mainfrom Oct 22, 2021
Conversation
a2c4ff0 to
8408670
Compare
RikkiGibson
approved these changes
Oct 21, 2021
...udio/Core/Def/Implementation/CodeDefinitionWindow/VisualStudioCodeDefinitionWindowService.cs
Show resolved
Hide resolved
...udio/Core/Def/Implementation/CodeDefinitionWindow/VisualStudioCodeDefinitionWindowService.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Oct 21, 2021
Member
|
@jasonmalinowski are we ready to enable auto-merge on this? |
If the symbol your caret is over is from metadata, producing the output might be really expensive, so let's not do it in that case. The window clears anything when it's opened, so the user won't know it was never doing anything when closed.
f7625d0 to
e3f5ffc
Compare
Member
Author
|
@RikkiGibson Now set. |
sharwell
reviewed
Oct 21, 2021
| var vsCodeDefView = await GetVsCodeDefViewAsync().ConfigureAwait(true); | ||
|
|
||
| // Switch to the UI thread before using the IVsCodeDefView service | ||
| await _threadingContext.JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); |
Contributor
There was a problem hiding this comment.
💡 This method will be more efficient if this call is moved to the start of the method (removes two thread context switches that would occur if the caller is on a background thread and the window is not already initialized, and no penalty for the other cases).
sharwell
reviewed
Oct 21, 2021
| var vsCodeDefView = await GetVsCodeDefViewAsync().ConfigureAwait(true); | ||
|
|
||
| // Switch to the UI thread before using the IVsCodeDefView service | ||
| await _threadingContext.JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); |
Contributor
There was a problem hiding this comment.
📝 This should also be moved up to before the call to GetServiceAsync (same reason)
sharwell
reviewed
Oct 21, 2021
| // so the user won't notice we weren't doing anything when it was open. | ||
| if (!await _codeDefinitionWindowService.IsWindowOpenAsync(cancellationToken).ConfigureAwait(false)) | ||
| { | ||
| return; |
Contributor
There was a problem hiding this comment.
❔ How much penalty is there for calling SetContextAsync with an empty set of locations for this case?
Member
Author
There was a problem hiding this comment.
What would be the goal of doing that? Its entirely possible the service will throw away the call, I'm not certain.
This was referenced Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the symbol your caret is over is from metadata, producing the output might be really expensive, so let's not do it in that case. The window clears anything when it's opened, so the user won't know it was never doing anything when closed.