Integration tests for analyzers that use MS.CA.CSharp.Workspaces and MS.CA.VB.Workspaces#57305
Closed
akhera99 wants to merge 2 commits intodotnet:mainfrom
Closed
Conversation
genlu
approved these changes
Oct 21, 2021
Member
There was a problem hiding this comment.
So we don't have any code style analyzer tests?
update:
I was trying to run existing integration tests locally with core host enabled, and it turns out many tests fail because of the missing vsix analyzer assets (e.g. CSharpErrorListNetCore tests), which is an epic failure on me cause I should have ran them at the beginning. I will get though all integration tests to see if we ave other failures.
That said, it means we probably don't need this test to cover the scenario in the PR title
This was referenced Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tied to #57294
Still need to test them once integration tests are fixed.