Update TextSpan.cs#57300
Merged
RikkiGibson merged 2 commits intodotnet:mainfrom Oct 27, 2021
MarcioAB:patch-1
Merged
Conversation
Currently the documentation of Microsoft.CodeAnalysis.Text.TextSpan.ToString() is only "Provides a string representation for TextSpan." I propose to include the following text to improve understanding: "This representation uses "half-open interval" notation, indicating the endpoint character is not included. Example: [10..20), indicating the text starts at position 10 and ends at position 20 not included."
sharwell
reviewed
Oct 21, 2021
Member
|
Thanks for your PR @MarcioAB. I'm editing the PR description to make it reference the issue which is addressed by this PR. |
This was referenced Oct 22, 2021
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
jmarolf
approved these changes
Oct 26, 2021
RikkiGibson
approved these changes
Oct 26, 2021
Member
|
@dotnet/roslyn-compiler for 2nd review of a doc-only change |
jcouv
approved these changes
Oct 27, 2021
Member
|
Thanks for the contribution @MarcioAB! |
Contributor
Author
|
Looking forward to contributing more. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #57299
Currently the documentation of Microsoft.CodeAnalysis.Text.TextSpan.ToString() is only "Provides a string representation for TextSpan."
I propose to include the following text to improve understanding:
"This representation uses "half-open interval" notation, indicating the endpoint character is not included.
Example: [10..20), indicating the text starts at position 10 and ends at position 20 not included."