[LSP] Add feature flag to enable LSP classifications in local scenarios#57291
Merged
allisonchou merged 6 commits intodotnet:release/dev17.1from Oct 26, 2021
Merged
Conversation
davidwengier
approved these changes
Oct 21, 2021
dibarbet
approved these changes
Oct 21, 2021
| serverCapabilities.DisableGoToWorkspaceSymbols = !isLspEditorEnabled; | ||
|
|
||
| var isLspSemanticTokensEnabled = GlobalOptions.GetOption(LspOptions.LspSemanticTokensFeatureFlag); | ||
| if (isLspSemanticTokensEnabled) |
Member
There was a problem hiding this comment.
make sure that the liveshare server does not have this capability when enabled, otherwise both this and the liveshare server will attempt to provide semantic tokens
This was referenced Oct 22, 2021
Contributor
Author
|
@jinujoseph for m2 approval, the tests weren't passing on this so it missed the snap yesterday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new internal-only feature flag to enable LSP classifications in local scenarios. Everything seems to work as expected, although I'm unable to test multi-target framework scenarios due to this bug.
This PR should probably also go in around the same time as #57231 which improves the performance of the edit algorithm.
s/o to DavidB for the helpful advice on how to enable this!