Fix a race condition in CompilationWithAnalyzers#57260
Merged
mavasani merged 1 commit intodotnet:mainfrom Oct 22, 2021
Merged
Conversation
Added unit test scenario in this PR fails due to duplicate diagnostics prior to the product fix and should add as a regression test.
cston
reviewed
Oct 20, 2021
cston
approved these changes
Oct 20, 2021
333fred
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#56844 (merged a day ago) introduced a race condition wherein if we reuse the same CompilationWithAnalyzers instance for computing compiler semantic diagnostics for both line span (lightbulb) and full file span (background analysis for squiggles and error list), we end up reporting duplicate diagnostics from CompilationWithAnalyzers. This leads to seeing these duplicates in the error list. This change fixes that by ensuring we dedupe the reported compiler semantic diagnostics from CompilationWithAnalyzers.
Added unit test scenario in this PR fails due to duplicate diagnostics prior to the product fix and should act as a regression test for this issue.