Skip to content

Add ServiceHub core host integration test CI#57228

Merged
JoeRobich merged 4 commits intodotnet:mainfrom
genlu:OopCoreIntegrationTest
Oct 22, 2021
Merged

Add ServiceHub core host integration test CI#57228
JoeRobich merged 4 commits intodotnet:mainfrom
genlu:OopCoreIntegrationTest

Conversation

@genlu
Copy link
Copy Markdown
Member

@genlu genlu commented Oct 19, 2021

This depends on the change in #57223

@ghost ghost added the Area-Infrastructure label Oct 19, 2021
@runfoapp runfoapp bot mentioned this pull request Oct 19, 2021
Open
@genlu genlu mentioned this pull request Oct 21, 2021
Merged
1 task
@genlu genlu marked this pull request as ready for review October 21, 2021 20:45
@genlu genlu requested review from a team as code owners October 21, 2021 20:45
JoeRobich
JoeRobich approved these changes Oct 21, 2021
View reviewed changes
azure-pipelines-integration-corehost.yml
pool:
name: NetCorePublic-Pool
queue: $(queueName)
timeoutInMinutes: 135
Copy link
Copy Markdown
Member

@JoeRobich JoeRobich Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a matrix so we test both Release and Debug configurations. See example

roslyn/azure-pipelines-integration.yml

Lines 18 to 44 in e1b5726

- job: VS_Integration
pool:
name: $(poolName)
queue: $(queueName)
strategy:
maxParallel: 4
matrix:
debug_32:
_configuration: Debug
_oop64bit: false
debug_64:
_configuration: Debug
_oop64bit: true
release_32:
_configuration: Release
_oop64bit: false
release_64:
_configuration: Release
_oop64bit: true
timeoutInMinutes: 135
steps:
- template: eng/pipelines/test-integration-job.yml
parameters:
configuration: $(_configuration)
oop64bit: $(_oop64bit)
lspEditor: false

Copy link
Copy Markdown
Member Author

@genlu genlu Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use $(poolName) in this new leg as well?

Copy link
Copy Markdown
Member

@JoeRobich JoeRobich Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That isn't necessary. We use that for our scouting queue.

genlu and others added 2 commits October 21, 2021 14:30
@genlu @JoeRobich
Update comment
071b63c 
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
@genlu
Add release leg
136d206
This was referenced Oct 22, 2021
Closed
Closed
Closed
Closed
@genlu
Copy link
Copy Markdown
Member Author

genlu commented Oct 22, 2021

@JoeRobich The new CI pipeline seems to be working as expected.
https://dev.azure.com/dnceng/public/_build/results?buildId=1436555&view=ms.vss-test-web.build-test-results-tab&runId=41474486&resultId=100409&paneView=debug

Should I go ahead and merge this? How can I make sure the new core host legs are not blocking PRs?

@genlu genlu enabled auto-merge October 22, 2021 22:15
@genlu
Copy link
Copy Markdown
Member Author

genlu commented Oct 22, 2021 •
edited
Loading

@JoeRobich Merge is blocked by flaky integration tests. Could you force merge this please? I believe the change in shared files is validated by (failed) integration test runs. Thanks!

@JoeRobich JoeRobich disabled auto-merge October 22, 2021 23:35
@JoeRobich JoeRobich merged commit 145752d into dotnet:main Oct 22, 2021
@ghost ghost added this to the Next milestone Oct 22, 2021
@genlu genlu deleted the OopCoreIntegrationTest branch October 22, 2021 23:38
@genlu
Copy link
Copy Markdown
Member Author

genlu commented Oct 22, 2021

Thanks! @JoeRobich

@RikkiGibson RikkiGibson modified the milestones: Next, 17.1.P1 Oct 25, 2021
@jmarolf jmarolf mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees

No one assigned

Labels

Area-Infrastructure

Projects

None yet

Milestone

17.1.P1

Development

Successfully merging this pull request may close these issues.

3 participants

@genlu @JoeRobich @RikkiGibson