Disable async lightbulbs for 17.0#57169
Merged
jinujoseph merged 4 commits intodotnet:release/dev17.0from Oct 26, 2021
Merged
Conversation
Contributor
Author
|
Tagging @jinujoseph |
CyrusNajmabadi
commented
Oct 22, 2021
src/EditorFeatures/Core/Implementation/Suggestions/SuggestionsOptions.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Is there a bug for the latest/outstanding issues? |
davidwengier
approved these changes
Oct 22, 2021
mavasani
approved these changes
Oct 22, 2021
Contributor
Author
There is at least: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1422967 |
Contributor
Author
|
@jinujoseph for QB. |
jmarolf
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have had too many late minute issue arise in async lightbulbs (both in roslyn and platform). We only want this enabled (out of preview) when we have extremely high confidence that the impl can replace the sync one without expereince regressions. We're unfortunately not there yet, and we don't have enough time to get there, so we're disabling for 17.0.
Note: this will stay enabled (and the only supported lightbulb) in 17.1.