Only pass the lsp misc files workspace for non-VS scenarios. #56989
Merged
dibarbet merged 1 commit intodotnet:mainfrom Oct 7, 2021
Merged
Only pass the lsp misc files workspace for non-VS scenarios. #56989dibarbet merged 1 commit intodotnet:mainfrom
dibarbet merged 1 commit intodotnet:mainfrom
Conversation
…es in VSwill be handled by the VS misc files workspace instead of the lsp misc files workspace
davidwengier
approved these changes
Oct 7, 2021
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
@dibarbet Did this break something? I would have assumed that if we were still using the "regular" misc files workspace that would have just taken priority and the LSP one would have never done anything?
| private static Document? GetMiscellaneousDocument(TestLspServer testLspServer) | ||
| { | ||
| return testLspServer.GetQueueAccessor().GetLspMiscellaneousFilesWorkspace().CurrentSolution.Projects.SingleOrDefault()?.Documents.Single(); | ||
| return testLspServer.GetQueueAccessor().GetLspMiscellaneousFilesWorkspace()!.CurrentSolution.Projects.SingleOrDefault()?.Documents.Single(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc files in VSwill be handled by the VS misc files workspace instead of the lsp misc files workspace
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/356545
The previous misc files change broke RPS because we started loading dlls needed by the default mef host which was used by the LSP misc files workspace. We don't have access to the VS workspace mef composition (and it might not even exist when this is created). And we don't necessarily have a host workspace. So we just avoid creating it in VS