Add property to errors in errorlist to prevent the error service from…#56785
Merged
dibarbet merged 1 commit intodotnet:release/dev17.0from Sep 28, 2021
Merged
Conversation
… duplicating them to the guest in LiveShare
davidwengier
approved these changes
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… duplicating them to the guest in LiveShare
Errors for the liveshare guest are either produced via LSP publish diagnostics directly to the guest or, when pull diagnostics are enabled on the host, via LSP pull. Host error list errors should never be propagated to the guest.
Fixes - https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1378186 (introduced when the platform switched to using the diagnostics brokered service for LSP publish).