Skip to content

Set the width of Inheritance Margin to 18#56709

Merged
Cosifne merged 1 commit intodotnet:mainfrom
Cosifne:dev/shech/widthFix
Sep 25, 2021
Merged

Set the width of Inheritance Margin to 18#56709
Cosifne merged 1 commit intodotnet:mainfrom
Cosifne:dev/shech/widthFix

Conversation

@Cosifne
Copy link
Copy Markdown
Member

@Cosifne Cosifne commented Sep 24, 2021

When C#/VB -> Advanced -> Combine Inheritance Margin with Indicator margin is off
image

It is caused because the width is set to 17.

Change this value to 1 * 2 + 16 (2 * border + crisp image) = 18

image

Also do some code cleaning.

@Cosifne Cosifne requested a review from a team September 24, 2021 19:04
@ghost ghost added the Area-IDE label Sep 24, 2021
@Cosifne
Copy link
Copy Markdown
Member Author

Cosifne commented Sep 24, 2021

☹ Integration CIs stuck for 2 hours

@Cosifne
Copy link
Copy Markdown
Member Author

Cosifne commented Sep 24, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@Cosifne Cosifne merged commit 8635f76 into dotnet:main Sep 25, 2021
@Cosifne Cosifne deleted the dev/shech/widthFix branch September 25, 2021 06:28
@ghost ghost added this to the Next milestone Sep 25, 2021
@ghost ghost added the Needs UX Triage label Sep 25, 2021
@ryzngard ryzngard added UX Review Not Required UX Review Not Required and removed Needs UX Triage labels Sep 26, 2021
@Cosifne Cosifne modified the milestones: Next, 17.0.P5 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants