Filter out results from progression/lsp with docs that we can't get uris for#56700
Merged
CyrusNajmabadi merged 7 commits intodotnet:mainfrom Sep 25, 2021
Merged
Filter out results from progression/lsp with docs that we can't get uris for#56700CyrusNajmabadi merged 7 commits intodotnet:mainfrom
CyrusNajmabadi merged 7 commits intodotnet:mainfrom
Conversation
02e107b to
89f49db
Compare
89f49db to
37e4d40
Compare
dibarbet
approved these changes
Sep 24, 2021
| @@ -144,13 +144,14 @@ static async Task<char> GetInsertionCharacterAsync(Document document, int positi | |||
| public static Uri GetUriFromFilePath(string? filePath) | |||
Member
There was a problem hiding this comment.
should this be replaced entirely by TryGetUriFromFilePath?
Contributor
Author
There was a problem hiding this comment.
makes sense.
src/Features/LanguageServer/Protocol/Extensions/ProtocolConversions.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56607