Merged
Conversation
Member
Author
|
@CyrusNajmabadi This implements the options pattern I proposed last time we talked. LMK what you think. |
CyrusNajmabadi
approved these changes
Sep 23, 2021
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
I like it! I don't love the name 'definition', but I have no better suggestion.
Member
The LSP spec has Tokens and TokenModifiers. This seems like a Modifier option, whether to additionally tag an identifier as Reassigned. |
Member
Author
|
@CyrusNajmabadi |
Contributor
|
@tmat yes. I like that better. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of reading options the classification service needs from solution snapshot pass them to the service as a parameter. This makes it clear which options the service depends on and potentially allows us to reuse the results when unrelated options change.
We should use this pattern for all solution options used by remote services.