Skip to content

Update references for public 17.0 Preview 4 release #56626

Merged
sharwell merged 2 commits intodotnet:mainfrom
sharwell:preview4
Sep 24, 2021
Merged

Update references for public 17.0 Preview 4 release #56626
sharwell merged 2 commits intodotnet:mainfrom
sharwell:preview4

Conversation

@sharwell
Copy link
Copy Markdown
Contributor

@sharwell sharwell commented Sep 22, 2021

No description provided.

@ghost ghost added the Area-Infrastructure label Sep 22, 2021
@sharwell sharwell marked this pull request as ready for review September 23, 2021 00:04
@sharwell sharwell requested review from a team as code owners September 23, 2021 00:04
@jasonmalinowski
Copy link
Copy Markdown
Member

jasonmalinowski commented Sep 23, 2021

This is being coordinated with #56550?

@sharwell
Copy link
Copy Markdown
Contributor Author

sharwell commented Sep 23, 2021

@jasonmalinowski No, this change is part of updating main to work with the new 17.0 Preview 4 CI. It's possible for main-vs-deps to adopt dependencies newer than Preview 4.

@jasonmalinowski
Copy link
Copy Markdown
Member

jasonmalinowski commented Sep 23, 2021

@sharwell well even if it's going into both places, the changes aren't different that will create merge conflicts later for the infrastructure team?

@dibarbet
Copy link
Copy Markdown
Member

dibarbet commented Sep 23, 2021

@jasonmalinowski @sharwell I can just rebase my change on this once this merges to main-vs-deps. Shouldn't be a problem as long as we get that merge in relatively quickly. I only need the LSP package version update (which needs the new editor packages)

@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented Sep 24, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 24, 2021

Azure Pipelines successfully started running 3 pipeline(s).

@JoeRobich JoeRobich changed the title Update references for public 17.0 Preview 4 release Update references for public 17.0 Preview 4 release Sep 24, 2021
@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented Sep 24, 2021

@sharwell Integration tests are now passing on Preview 4.1. Not sure why the cla check isn't reporting. Let me know if you want this merged.

@sharwell sharwell merged commit 9c6c90c into dotnet:main Sep 24, 2021
@ghost ghost added this to the Next milestone Sep 24, 2021
@sharwell sharwell deleted the preview4 branch September 24, 2021 20:57
@Cosifne Cosifne modified the milestones: Next, 17.0.P5 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

+1 more reviewer

@ryzngard ryzngard ryzngard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Infrastructure

Projects

None yet

Milestone

17.0.P5

Development

Successfully merging this pull request may close these issues.

6 participants

@sharwell @jasonmalinowski @dibarbet @JoeRobich @ryzngard @Cosifne