Add test to ensure completion won't trigger execution of source generator#56593
Merged
genlu merged 5 commits intodotnet:mainfrom Sep 22, 2021
Merged
Add test to ensure completion won't trigger execution of source generator#56593genlu merged 5 commits intodotnet:mainfrom
genlu merged 5 commits intodotnet:mainfrom
Conversation
jasonmalinowski
approved these changes
Sep 21, 2021
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Looks great other than one tiny concern.
| [Fact] | ||
| public async Task PartialCompilationsIncludeGeneratedFilesAfterFullGeneration() | ||
| { | ||
| using var workspace = CreateWorkspaceWithPartalSemantics(); |
Member
There was a problem hiding this comment.
Want to do a static using since we'll probably have this used more in this file down the road?
| MarkupTestFile.GetPosition(sourceMarkup.NormalizeLineEndings(), out var source, out int? position); | ||
|
|
||
| var generatorRanCount = 0; | ||
| var generator = new CallbackGenerator(onInit: _ => { }, onExecute: _ => { generatorRanCount++; }); |
Member
There was a problem hiding this comment.
Do an Interlocked.Increment() here to avoid any potential race. It's not hugely important since you're asserting that the count is simply zero at the end, so even if we were to somehow run in parallel the test would fail; I worry that either it'll get copy/pasted, or we'll have a bug where it's running in parallel and confuse whoever is trying to debug the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final piece of #55578
@jasonmalinowski