Clean up loc strings#56559
Merged
jmarolf merged 4 commits intodotnet:release/dev17.0from Sep 23, 2021
Merged
Conversation
Contributor
|
I'm curious why the directio here goes from Editor to VS. |
| yield return WhitespaceSetting.Create(CSharpFormattingOptions2.WrappingPreserveSingleLine, CSharpVSResources.Leave_block_on_single_line, editorConfigOptions, visualStudioOptions, updaterService, FileName); | ||
| yield return WhitespaceSetting.Create(CSharpFormattingOptions2.WrappingKeepStatementsOnSingleLine, CSharpVSResources.Leave_statements_and_member_declarations_on_the_same_line, editorConfigOptions, visualStudioOptions, updaterService, FileName); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
what caused this big add?
Contributor
Author
There was a problem hiding this comment.
This isn't an add this is a move. Github just doesn't know how to display moves correctly. I would review this PR one commit at a time
Contributor
Author
Because all the strings live in the VS layer. I could work to move all the Tools-> options code down to editor but that does not really make sense to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ran some tooling to find duplicate loc strings. There are actually a lot duplication in the codestyle layer that I will follow up on