Enable async lightbulbs by default#56551
Merged
CyrusNajmabadi merged 17 commits intodotnet:release/dev17.1-preview1-vs-depsfrom Sep 22, 2021
Merged
Enable async lightbulbs by default#56551CyrusNajmabadi merged 17 commits intodotnet:release/dev17.1-preview1-vs-depsfrom
CyrusNajmabadi merged 17 commits intodotnet:release/dev17.1-preview1-vs-depsfrom
Conversation
2cf1b42 to
b21c962
Compare
jasonmalinowski
approved these changes
Sep 20, 2021
|
|
||
| public static readonly Option2<bool> AsynchronousFeatureFlag = new(FeatureName, nameof(AsynchronousFeatureFlag), defaultValue: false, | ||
| new FeatureFlagStorageLocation("Roslyn.AsynchronousQuickActions")); | ||
| public static readonly Option2<bool> AsynchronousQuickActionsDisableFeatureFlag = new(FeatureName, nameof(AsynchronousQuickActionsDisableFeatureFlag), defaultValue: false, |
Member
There was a problem hiding this comment.
Consider having a tracking item or a comment discussing when we might want to sunset this. Writing a comment of "we should get rid of this by September 2022" obviously makes zero guarantee that'll actually happen, but it means somebody five years from now knows this can probably go.
b35a58e to
ef63c48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this also comes with a control tower variable to allow us to remotely disable if we run into any issues in teh wild we didn't forsee.
--
Results of A/B experiment showed no issues. 1600 people got the treatment and we observed no ill effects in our guardrails, and no feedback on the experience (beyond the known UI issue which editor has fixed).