Do not commit rename session when debugging starts#56519
Merged
tmat merged 3 commits intodotnet:mainfrom Sep 18, 2021
Merged
Conversation
Member
Author
|
@jasonmalinowski ptal |
CyrusNajmabadi
approved these changes
Sep 18, 2021
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Yes. The less special behavior we have arrived debugging, the better.
Member
|
@tmat Behavior change makes sense to me; I'd be curious how well E&C handles all the insanity we do while doing inline rename edits... 😄 |
Member
Author
|
It already has to handle that since you can start renaming after starting debugging session. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior creates inconsistency between F5 and Ctrl+F5.
It is perfectly fine to complete a rename while the app is running. The change will be picked up by EnC/Hot Reload.