Make abstract type actually implement interface.#56488
Merged
CyrusNajmabadi merged 4 commits intodotnet:mainfrom Sep 18, 2021
Merged
Make abstract type actually implement interface.#56488CyrusNajmabadi merged 4 commits intodotnet:mainfrom
CyrusNajmabadi merged 4 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Sep 17, 2021
|
|
||
| Private Function ISyntaxFacts_IsMultiLineDocCommentTrivia(trivia As SyntaxTrivia) As Boolean Implements ISyntaxFacts.IsMultiLineDocCommentTrivia | ||
| Return MyBase.IsMultiLineDocCommentTrivia(trivia) | ||
| Return False |
CyrusNajmabadi
commented
Sep 17, 2021
| => SyntaxKinds.MultiLineDocCommentTrivia == trivia.RawKind; | ||
|
|
||
| public bool IsShebangDirectiveTrivia(SyntaxTrivia trivia) | ||
| => SyntaxKinds.ShebangDirectiveTrivia == trivia.RawKind; |
Contributor
Author
There was a problem hiding this comment.
moved to extensions. tehre is no instance data needed to answer these questions. fits new pattern.
CyrusNajmabadi
commented
Sep 17, 2021
|
|
||
| Public Function ISyntaxFacts_HasIncompleteParentMember(node As SyntaxNode) As Boolean Implements ISyntaxFacts.HasIncompleteParentMember | ||
| Return HasIncompleteParentMember(node) | ||
| End Function |
Contributor
Author
There was a problem hiding this comment.
vb does not allow a base type to implicitly implement interfaces declared on the derived type. so tehse impl+forwarding methods were needed. THey can no go since the base type does impl the interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why this abstract class wasn't implenting the interface it claimed to. This made life difficult as it meant that hte abstract type couldn't refer to extensions on the interface it was supposed to be implementing.