Fix partial method doc comments#56419
Merged
RikkiGibson merged 8 commits intodotnet:mainfrom Sep 21, 2021
Merged
Conversation
jcouv
reviewed
Sep 16, 2021
jcouv
reviewed
Sep 16, 2021
jcouv
reviewed
Sep 16, 2021
src/Compilers/CSharp/Test/Symbol/DocumentationComments/DocumentationCommentCompilerTests.cs
Show resolved
Hide resolved
AlekseyTs
reviewed
Sep 16, 2021
src/Compilers/CSharp/Test/Symbol/DocumentationComments/DocumentationCommentCompilerTests.cs
Show resolved
Hide resolved
AlekseyTs
reviewed
Sep 16, 2021
src/Compilers/CSharp/Portable/Compiler/DocumentationCommentCompiler.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
AlekseyTs
reviewed
Sep 16, 2021
src/Compilers/CSharp/Test/Symbol/DocumentationComments/DocumentationCommentCompilerTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Sep 16, 2021
src/Compilers/CSharp/Test/Symbol/DocumentationComments/DocumentationCommentCompilerTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Sep 16, 2021
src/Compilers/CSharp/Test/Symbol/DocumentationComments/DocumentationCommentCompilerTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Sep 16, 2021
src/Compilers/CSharp/Test/Symbol/DocumentationComments/DocumentationCommentCompilerTests.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Do we need sign off from @dotnet/roslyn-ide for new tests in the IDE area? |
Member
|
Yes, we should get a review for the few added IDE tests. |
| @"partial class MyClass | ||
| { | ||
| ///<summary>My Method Definition</summary> | ||
| public partial void MyMethod(); |
Contributor
There was a problem hiding this comment.
can you add one more test where there is only an impl, but no def.
| @"partial class MyClass | ||
| { | ||
| ///<summary>My Method Definition</summary> | ||
| public partial void MyMethod(); |
Contributor
There was a problem hiding this comment.
any concern that all thse tests test the public case? i know ublic partials are different from nonpublic ones. would testing that be useful? or is all the same to the compiler?
Member
Author
There was a problem hiding this comment.
or is all the same to the compiler?
I think it is, but I added one test where the partial method has no access modifiers for good measure.
CyrusNajmabadi
approved these changes
Sep 21, 2021
This was referenced Jan 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54103.
The specific rule changes implemented in this PR are laid out in dotnet/csharplang#5193.
Have added tests to ensure that the expected documentation is shown in Quick Info.