Factor process telemetry service out of RemoteHostService#56329
Merged
tmat merged 7 commits intodotnet:mainfrom Sep 14, 2021
Merged
Factor process telemetry service out of RemoteHostService#56329tmat merged 7 commits intodotnet:mainfrom
tmat merged 7 commits intodotnet:mainfrom
Conversation
36a13fd to
a673c32
Compare
tmat
commented
Sep 11, 2021
CyrusNajmabadi
approved these changes
Sep 13, 2021
sharwell
reviewed
Sep 13, 2021
...te/ServiceHub/Services/ProcessTelemetry/RemoteProcessTelemetryService.PerformanceReporter.cs
Show resolved
Hide resolved
sharwell
suggested changes
Sep 13, 2021
Contributor
sharwell
left a comment
There was a problem hiding this comment.
Generally seems fine, but would like to see an eager evaluation returned to lazy
sharwell
reviewed
Sep 14, 2021
sharwell
approved these changes
Sep 14, 2021
9eac5a2 to
d6de085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.