Read StorageOptions from solution snapshot.#56307
Merged
tmat merged 6 commits intodotnet:mainfrom Sep 14, 2021
Merged
Conversation
d4095fe to
95ceea1
Compare
Removes Microsoft.CodeAnalysis.PersistentStorage namespace (move 3 types from this namespace to Microsoft.CodeAnalysis.Storage). Read options that determine the database kind (StorageDatabase) from solution options and pass the kind along. Previously the options were read when the persistent storage workspace service was created, using an undefined solution snapshot (which may or may not have the options correctly set) current to the workspace at that time.
95ceea1 to
edb6944
Compare
CyrusNajmabadi
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read options that determine the database kind (StorageDatabase) from solution options and pass the kind along. Previously the options were read when the persistent storage workspace service was created, using an undefined solution snapshot (which may or may not have the options correctly set) current to the workspace at that time.
Removes Microsoft.CodeAnalysis.PersistentStorage namespace (move 3 types from this namespace to Microsoft.CodeAnalysis.Storage).
Contributes to #55728