Skip to content

Flip driver cache from opt-out to opt-in#56250

Merged
jaredpar merged 1 commit intodotnet:release/dev17.0-vs-depsfrom
chsienki:source-generators/cache-additional-files-fix
Sep 8, 2021
Merged

Flip driver cache from opt-out to opt-in#56250
jaredpar merged 1 commit intodotnet:release/dev17.0-vs-depsfrom
chsienki:source-generators/cache-additional-files-fix

Conversation

@chsienki
Copy link
Copy Markdown
Member

@chsienki chsienki commented Sep 8, 2021

Flips the feature flag around and updates tests

@chsienki chsienki requested a review from a team as a code owner September 8, 2021 18:06
@chsienki chsienki changed the base branch from main to release/dev17.0 September 8, 2021 18:07
@chsienki chsienki force-pushed the source-generators/cache-additional-files-fix branch from 83f162f to 1b689df Compare September 8, 2021 19:23
@chsienki chsienki requested review from a team as code owners September 8, 2021 19:23
@chsienki chsienki requested a review from a team September 8, 2021 19:23
@chsienki chsienki changed the base branch from release/dev17.0 to release/dev17.0-vs-deps September 8, 2021 19:23
@chsienki chsienki removed request for a team September 8, 2021 19:23
@chsienki chsienki changed the title Ensure the driver cache updates non compiler inputs: Flip driver cache from opt-out to opt-in Sep 8, 2021
@chsienki chsienki enabled auto-merge (squash) September 8, 2021 19:53
@jaredpar
Copy link
Copy Markdown
Member

jaredpar commented Sep 8, 2021

This is a time critical PR. Tests have passed on desktop 32 debug / release as well as manually. Going to force merge now. Will keep an eye on the merged PR CI run. But need to get the code flow going to the dotnet/sdk repository.

@jaredpar jaredpar disabled auto-merge September 8, 2021 20:32
@jaredpar jaredpar merged commit 2bfff7b into dotnet:release/dev17.0-vs-deps Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants