Include ref info for parameters > 16 in synthesized delegate type name#56233
Merged
cston merged 1 commit intodotnet:mainfrom Sep 9, 2021
Merged
Include ref info for parameters > 16 in synthesized delegate type name#56233cston merged 1 commit intodotnet:mainfrom
cston merged 1 commit intodotnet:mainfrom
Conversation
cston
commented
Sep 7, 2021
| builder.Append("{"); | ||
|
|
||
| int i = 0; | ||
| foreach (int byRefIndex in this.Words()) |
Contributor
Author
Member
There was a problem hiding this comment.
🤣 I probably should have noticed that when I moved the code
Member
There was a problem hiding this comment.
The language/tooling should have guard rails in place to make this harder to do by accident. Unfortunate that there isn't a reasonable place for people to insert an "explicit" cast.
RikkiGibson
approved these changes
Sep 8, 2021
333fred
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55570.