Merge all source generator state in CompilationTracker into a helper type.#56229
Merged
CyrusNajmabadi merged 25 commits intodotnet:mainfrom Sep 9, 2021
Merged
Merge all source generator state in CompilationTracker into a helper type.#56229CyrusNajmabadi merged 25 commits intodotnet:mainfrom
CyrusNajmabadi merged 25 commits intodotnet:mainfrom
Conversation
jasonmalinowski
approved these changes
Sep 8, 2021
Comment on lines
+52
to
+56
| public CompilationTrackerGeneratorInfo WithDocumentsAreFinal(bool documentsAreFinal) | ||
| => DocumentsAreFinal == documentsAreFinal ? this : new(Documents, Driver, documentsAreFinal); | ||
|
|
||
| public CompilationTrackerGeneratorInfo WithDriver(GeneratorDriver? driver) | ||
| => Driver == driver ? this : new(Documents, driver, DocumentsAreFinal); |
Member
There was a problem hiding this comment.
Make this a record so we don't have to write these?
Contributor
Author
There was a problem hiding this comment.
records don't operate this way :) they always produce a new instance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #56139