Merged
Conversation
jcouv
reviewed
Aug 30, 2021
jcouv
reviewed
Aug 30, 2021
|
|
||
| string ISymbol.MetadataName => _name; | ||
|
|
||
| int ISymbol.MetadataToken => 0; |
Member
There was a problem hiding this comment.
Are non-PE symbols covered in tests? #Closed
Member
Author
There was a problem hiding this comment.
There aren't explicit asserts that the value is 0, no. Will add some.
Member
Author
There was a problem hiding this comment.
Added a simple test. Not sure if there was anywhere else specifically these checks should be added?
RikkiGibson
reviewed
Aug 30, 2021
Member
RikkiGibson
left a comment
There was a problem hiding this comment.
Done with review pass (iteration 5).
src/Compilers/VisualBasic/Portable/Symbols/Metadata/PE/PEMethodSymbol.vb
Outdated
Show resolved
Hide resolved
src/Compilers/VisualBasic/Portable/Symbols/Metadata/PE/PEMethodSymbol.vb
Outdated
Show resolved
Hide resolved
src/Compilers/VisualBasic/Portable/Symbols/Metadata/PE/PEMethodSymbol.vb
Outdated
Show resolved
Hide resolved
RikkiGibson
approved these changes
Sep 4, 2021
Member
Author
|
Ping @dotnet/roslyn-compiler / @jcouv for second review |
11 tasks
Member
Author
|
Ping @jcouv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53486
Needed for #55834