Extract async navigation portions of https://github.com/dotnet/roslyn/pull/55635#55891
Merged
CyrusNajmabadi merged 46 commits intodotnet:mainfrom Aug 26, 2021
Merged
Extract async navigation portions of https://github.com/dotnet/roslyn/pull/55635#55891CyrusNajmabadi merged 46 commits intodotnet:mainfrom
CyrusNajmabadi merged 46 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Aug 25, 2021
| FunctionId.CommandHandler_FindAllReference, | ||
| KeyValueLogMessage.Create(LogType.UserAction, m => m["type"] = "streaming"), | ||
| cancellationToken)) | ||
| try |
Contributor
Author
There was a problem hiding this comment.
this is jus tmoving to a try/finally so all return paths call ONCompletedAsync.
Contributor
Author
There was a problem hiding this comment.
viewing this PR with whitespace off will help.
CyrusNajmabadi
commented
Aug 25, 2021
| i => GoToDefinitionHelpers.GetDefinitions( | ||
| i, solution, thirdPartyNavigationAllowed: false, cancellationToken)).ToImmutableArray(); | ||
|
|
||
| var title = string.Format(EditorFeaturesResources._0_implemented_members, |
Contributor
Author
There was a problem hiding this comment.
this entire synchronous codepath will hopefully go away in a future PR.
davidwengier
approved these changes
Aug 26, 2021
Member
davidwengier
left a comment
There was a problem hiding this comment.
I can't comment on the implications of this but that changes themselves seem okay ¯\_(ツ)_/¯
| if (presenter != null) | ||
| { | ||
| // Can only navigate or present items on UI thread. | ||
| await threadingContext.JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); |
Member
There was a problem hiding this comment.
@CyrusNajmabadi there's a bunch of ConfigureAwait(false)es after this -- expected?
Contributor
Author
There was a problem hiding this comment.
taken offline. yes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#55635 Is a bit large in the amount of change it causes (and potential risk it introduces). Thsi PR pulls out the portions of that PR that update several codepaths to be async and to avoid sync-over-async-over-sync-etc.