Skip to content

Add more attribute tests for more things#55881

Merged
davidwengier merged 2 commits intodotnet:mainfrom
davidwengier:EnCMoreAttributeTests
Aug 30, 2021
Merged

Add more attribute tests for more things#55881
davidwengier merged 2 commits intodotnet:mainfrom
davidwengier:EnCMoreAttributeTests

Conversation

@davidwengier
Copy link
Copy Markdown
Member

Fixes #54430

}

[Fact]
public void Attributes()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attributes

What CA metadata targets should this test cover?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields, Properties and Types. Will rename. It started life as just delegates, but combining them all made more sense in the end.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about events? Parameters? ...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're in other existing tests.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I linked to each of the PRs in #54430

@davidwengier davidwengier enabled auto-merge (squash) August 26, 2021 03:56
@davidwengier
Copy link
Copy Markdown
Member Author

Ping @tmat

Copy link
Copy Markdown
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier merged commit bd5b482 into dotnet:main Aug 30, 2021
@ghost ghost added this to the Next milestone Aug 30, 2021
@davidwengier davidwengier deleted the EnCMoreAttributeTests branch August 30, 2021 22:56
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EnC - More attribute edit tests

3 participants