Skip to content

Change preview pane to hide unusable options#55775

Merged
ryzngard merged 1 commit intodotnet:mainfrom
ryzngard:issues/preview_pane_editor_settings
Aug 24, 2021
Merged

Change preview pane to hide unusable options#55775
ryzngard merged 1 commit intodotnet:mainfrom
ryzngard:issues/preview_pane_editor_settings

Conversation

@ryzngard
Copy link
Contributor

Hides the indentation and EOL settings at the bottom of the editor in the preview pane. These don't work correctly, and instead change the settings for another open document.

ea99e971-4226-4791-87e0-160ced525e80

Before:

image

After:

image

@ryzngard ryzngard requested a review from a team as a code owner August 20, 2021 23:47
@ghost ghost added the Area-IDE label Aug 20, 2021
@ryzngard ryzngard requested a review from sharwell August 20, 2021 23:48
@jasonmalinowski
Copy link
Member

@ryzngard Should we also hide the "No issues found", because I don't think that's going to ever say anything else?

@ryzngard
Copy link
Contributor Author

@ryzngard Should we also hide the "No issues found", because I don't think that's going to ever say anything else?

I'm okay to remove that as well. I left it because I think it could say something else if a refactoring would introduce an analyzer warning/error, but I haven't tested

@ryzngard ryzngard merged commit c083dae into dotnet:main Aug 24, 2021
@ghost ghost added this to the Next milestone Aug 24, 2021
@ryzngard ryzngard deleted the issues/preview_pane_editor_settings branch August 24, 2021 04:24
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasonmalinowski
Copy link
Member

@ryzngard: as best I can tell it's just broken, so filed #56074.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants