Fix typing in rename preview changes#55774
Merged
ryzngard merged 1 commit intodotnet:mainfrom Aug 31, 2021
Merged
Conversation
…uffer that is not tracked as open in the workspace. This prevents keys from being intercepted when a user tries to type in the preview window
davidwengier
approved these changes
Aug 23, 2021
Comment on lines
+891
to
+892
| internal bool IsInOpenTextBuffer(SnapshotPoint point) | ||
| => _openTextBuffers.ContainsKey(point.Snapshot.TextBuffer); |
Member
There was a problem hiding this comment.
This might be my lack of context, but when I read IsInOpenTextBuffer(SnapshotPoint) I think "Is this point in any open text buffer". Realistically this method is actually "Is this buffer open", so I think it would make more sense to have the parameter here be a ITextBuffer and put the .Shapshot.TextBuffer bit in the caller on line 79.
Contributor
Author
There was a problem hiding this comment.
Sort of. Technically it's "Is this point in any open buffer that is being tracked". The point is still in an open buffer, but it's tracked by a separate workspace when doing a preview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When typing in preview changes, which is a readonly text buffer, the inline rename engine was defaulting to try and commit again. This results in extra modal dialogs being open that can't be closed. Fix by checking that the open buffers contains the area that is attempting to be edited before trying to commit. For the case of the preview pane, the open buffers are tracked differently.
Fixes #54876