Call new document formatting service from extract type#55522
Merged
davidwengier merged 2 commits intodotnet:mainfrom Aug 12, 2021
Merged
Call new document formatting service from extract type#55522davidwengier merged 2 commits intodotnet:mainfrom
davidwengier merged 2 commits intodotnet:mainfrom
Conversation
dibarbet
approved these changes
Aug 12, 2021
src/EditorFeatures/CSharpTest/ExtractClass/ExtractClassTests.cs
Outdated
Show resolved
Hide resolved
ryzngard
approved these changes
Aug 12, 2021
| <Workspace> | ||
| <Project Language=""C#""> | ||
| <Document FilePath=""Test.cs"">// this is my document header | ||
| // that should be ignored |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| // that should be ignored | |
| // that should be changed |
Member
Author
There was a problem hiding this comment.
um.. I don't understand?
This header is ignored because its overridden by the real document header from the setting, when creating the new file, but the existing file is not affected at all. The "File banner incorrect" analyzer would presumably trigger on this, however.
jmarolf
approved these changes
Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes Extract Type/Interface use the new document formatting service, so it now supports file header templates from .editorconfig, and using directive placement options, and other fun things.