Try to fix the analyzer path when loading in OOP#55520
Merged
genlu merged 2 commits intodotnet:mainfrom Aug 10, 2021
Merged
Conversation
This is a hack to temporarily unblock further investigations
RikkiGibson
approved these changes
Aug 10, 2021
AraHaan
reviewed
Aug 10, 2021
| // For analyzers shipped in Roslyn, different set of assemblies might be used when running | ||
| // in-proc and OOP e.g. in-proc (VS) running on desktop clr and OOP running on ServiceHub .Net6 | ||
| // host. We need to make sure to use the ones from the same location as the remote. | ||
| private class RemoteAnalyzerAssemblyLoader : DefaultAnalyzerAssemblyLoader |
Member
There was a problem hiding this comment.
Don't this need tests added for it to verify that this fully works?
Member
Author
There was a problem hiding this comment.
You are absolutely right. However, the best way to test this (and anything related to .net6 servicehub host) is via integration tests, which I will enable once all the required bits are available on our test machines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just cherry-picking the change from main-vs-deps to main, to make it easier to resolve potential conflict with #55098. They were originally made in #55425
FYI @tmat @RikkiGibson