Skip to content

Annotate SyntaxFacts.IsValidIdentifier#55509

Merged
jcouv merged 1 commit intodotnet:mainfrom
Youssef1313:patch-16
Aug 10, 2021
Merged

Annotate SyntaxFacts.IsValidIdentifier#55509
jcouv merged 1 commit intodotnet:mainfrom
Youssef1313:patch-16

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 9, 2021

Fixes #55507

@Youssef1313 Youssef1313 requested a review from a team as a code owner August 9, 2021 18:29
@ghost ghost added the Area-Compilers label Aug 9, 2021
@RikkiGibson RikkiGibson self-assigned this Aug 9, 2021
jcouv
jcouv approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Aug 9, 2021
@jcouv jcouv merged commit 1ceccc6 into dotnet:main Aug 10, 2021
@ghost ghost added this to the Next milestone Aug 10, 2021
@Youssef1313 Youssef1313 deleted the patch-16 branch August 10, 2021 18:37
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@RikkiGibson RikkiGibson

@jcouv jcouv

Labels

Area-Compilers

Projects

None yet

Milestone

17.0.P4

Development

Successfully merging this pull request may close these issues.

Annotate public API 'SyntaxFacts.IsValidIdentifier' parameter as NotNullWhen(true)

4 participants

@Youssef1313 @RikkiGibson @jcouv @dibarbet