Format new document namespace declarations#55504
Merged
davidwengier merged 2 commits intodotnet:mainfrom Aug 10, 2021
Merged
Conversation
c96b930 to
f06c9a2
Compare
ryzngard
reviewed
Aug 10, 2021
| } | ||
|
|
||
| [Fact] | ||
| public async Task TestFileScopedNamespaces_Invalid1() |
Contributor
There was a problem hiding this comment.
Invalid{1, 2} could use an explanation of why they are invalid. It took me a second to realize 2 was because of the language version.
ryzngard
reviewed
Aug 10, 2021
| return TestCoreAsync<object>(testCode, expected, options: null, parseOptions: null); | ||
| } | ||
|
|
||
| internal Task TestAsync<T>(string testCode, string expected, (PerLanguageOption2<T>, T)[]? options = null, ParseOptions? parseOptions = null) |
Contributor
There was a problem hiding this comment.
Is there a test with multiple (PerLanguageOption2<T>, T) values?
Member
Author
There was a problem hiding this comment.
No, there isn't. I could simplify this I guess.
Member
Author
There was a problem hiding this comment.
Actually, decided to leave it. I don't think it causes much pain, and its reasonable future proofing
ryzngard
approved these changes
Aug 10, 2021
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55417