Register missing encoding providers for core host#55490
Merged
genlu merged 1 commit intodotnet:main-vs-depsfrom Aug 9, 2021
Merged
Register missing encoding providers for core host#55490genlu merged 1 commit intodotnet:main-vs-depsfrom
genlu merged 1 commit intodotnet:main-vs-depsfrom
Conversation
tmat
approved these changes
Aug 7, 2021
kasperk81
reviewed
Aug 9, 2021
| // we set up logger here | ||
| RoslynLogger.SetLogger(new EtwLogger(s_logChecker)); | ||
|
|
||
| // Make encodings that is by default present in desktop framework but not in corefx available to runtime. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Make encodings that is by default present in desktop framework but not in corefx available to runtime. | |
| // Make encodings that is by default present in desktop framework but not in corehost available to runtime. |
Contributor
|
why did you ignore the typo comment @genlu? |
Member
Author
|
@kasperk81 It's not a typo: the encodings are missing not because we are running on servicehub core host, it's actually the default in corefx. |
Contributor
|
Ok, though these days corefx is called runtime libraries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #54985