Skip to content

Remove obsolete UnitTesting and Razor External Access APIs#55484

Merged
tmat merged 2 commits intodotnet:mainfrom
tmat:ObsoleteUT
Aug 10, 2021
Merged

Remove obsolete UnitTesting and Razor External Access APIs#55484
tmat merged 2 commits intodotnet:mainfrom
tmat:ObsoleteUT

Conversation

@tmat
Copy link
Member

@tmat tmat commented Aug 6, 2021

No description provided.

@tmat tmat requested a review from a team as a code owner August 6, 2021 23:36
@ghost ghost added the Area-IDE label Aug 6, 2021
@tmat
Copy link
Member Author

tmat commented Aug 6, 2021

@shyamnamboodiripad

@shyamnamboodiripad
Copy link
Contributor

shyamnamboodiripad commented Aug 7, 2021 •
edited
Loading

Based on code search the following types are still used on UT side - so the obsolete attributes may have been added in error -

  • UnitTestingRemoteServiceConnectionWrapper
  • UnitTestingIncrementalAnalyzerProvider

--
[Update] Ah wait the type that is used is Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Api.UnitTestingIncrementalAnalyzerProvider while the type that is being removed is Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.UnitTestingIncrementalAnalyzerProvider.

Similarly Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Api.UnitTestingRemoteServiceConnectionWrapper<T> is being used, but the type being removed is Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Api.UnitTestingRemoteServiceConnectionWrapper (non-generic).

So it may be ok to remove both.

@shyamnamboodiripad
Copy link
Contributor

shyamnamboodiripad commented Aug 7, 2021

@tmat Its late today but I'll build UT against the changes in the current PR on Monday to double check that this doesn't break anything. I'll post an update once I do that.

@tmat tmat requested a review from a team as a code owner August 9, 2021 21:49
@tmat
Copy link
Member Author

tmat commented Aug 9, 2021

@NTaylorMullen PTAL

@tmat tmat changed the title Remove obsolete UnitTesting External Access APIs Remove obsolete UnitTesting and Razor External Access APIs Aug 9, 2021
shyamnamboodiripad
shyamnamboodiripad approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@shyamnamboodiripad shyamnamboodiripad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾 I did a quick smoke test to double check that this doesn't break anything for UT.

NTaylorMullen
NTaylorMullen approved these changes Aug 10, 2021
View reviewed changes
Copy link

@NTaylorMullen NTaylorMullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-checked all the API removals and they look good from Razor's standpoint.

@tmat tmat merged commit 3d0d948 into dotnet:main Aug 10, 2021
@tmat tmat deleted the ObsoleteUT branch August 10, 2021 20:32
@ghost ghost added this to the Next milestone Aug 10, 2021
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shyamnamboodiripad shyamnamboodiripad shyamnamboodiripad approved these changes

+1 more reviewer

@NTaylorMullen NTaylorMullen NTaylorMullen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

17.0.P4

Development

Successfully merging this pull request may close these issues.

4 participants

@tmat @shyamnamboodiripad @NTaylorMullen @dibarbet