Protect baseline readers from disposal while in use#55482
Merged
tmat merged 1 commit intodotnet:mainfrom Aug 10, 2021
Merged
Conversation
Member
Author
davidwengier
approved these changes
Aug 7, 2021
ryzngard
approved these changes
Aug 7, 2021
After further review, it is my recommendation that this code be modified such that EmitBaseline owns the resources governing its valid lifetime. Until that refactoring is complete, it may not be possible to verify correctness of these paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will help diagnose errors like AB#1363929