MEF import completion providers in background#55448
Merged
genlu merged 3 commits intodotnet:mainfrom Aug 6, 2021
Merged
Conversation
sharwell
reviewed
Aug 5, 2021
Comment on lines
59
to
68
| var serviceTypeAssemblyQualifiedName = typeof(ISnippetInfoService).AssemblyQualifiedName; | ||
| foreach (var languageService in _languageServices) | ||
| { | ||
| if (languageService.Metadata.ServiceType == serviceTypeAssemblyQualifiedName && | ||
| languageService.Metadata.Language == languageName) | ||
| languageService.Metadata.Language == _languageName) | ||
| { | ||
| _ = languageService.Value; | ||
| break; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
❔ Can this entire method be reduced now that we have the workspace?
_workspace.Services.GetLanguageService<ISnippetInfoService>(_languageName);
Member
Author
There was a problem hiding this comment.
Not sure about this, it seems getting LS from workspace could be slightly more expensive so we might still want to avoid doing it on UI thread?
sharwell
approved these changes
Aug 5, 2021
Contributor
sharwell
left a comment
There was a problem hiding this comment.
I definitely prefer this solution.
sharwell
reviewed
Aug 5, 2021
...Studio/Core/Def/Implementation/LanguageService/AbstractCreateServicesOnTextViewConnection.cs
Outdated
Show resolved
Hide resolved
…actCreateServicesOnTextViewConnection.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
sharwell
reviewed
Aug 5, 2021
...Studio/Core/Def/Implementation/LanguageService/AbstractCreateServicesOnTextViewConnection.cs
Outdated
Show resolved
Hide resolved
…actCreateServicesOnTextViewConnection.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Merged
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
👍 thanks for the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix AB#1242321