Skip to content

prevent Editor's typing responsiveness canceling the rename operation#55447

Merged
genlu merged 1 commit intodotnet:mainfrom
AmadeusW:dev/amwieczo/inlineRenameTwdUx
Aug 5, 2021
Merged

prevent Editor's typing responsiveness canceling the rename operation#55447
genlu merged 1 commit intodotnet:mainfrom
AmadeusW:dev/amwieczo/inlineRenameTwdUx

Conversation

@AmadeusW
Copy link
Copy Markdown
Contributor

@AmadeusW AmadeusW commented Aug 5, 2021

Problem:
VS Editor will restore the Typing Responsiveness auto-canceling the UI operation after a set delay.
This will cause the Threaded Wait Dialog to display the "Exceeded the execution timeout" message
image

Solution:
This fix prevents the operation from timing out. The Dialog will no longer display the timeout message.
This gif shows vastly exaggerated delays during inline rename. Editor is set to cancel the operation after 250ms.
roslyn individual operation context

@AmadeusW AmadeusW requested a review from a team as a code owner August 5, 2021 22:08
@ghost ghost added the Area-IDE label Aug 5, 2021
@AmadeusW
Copy link
Copy Markdown
Contributor Author

AmadeusW commented Aug 5, 2021

@genlu FYI

@genlu
Copy link
Copy Markdown
Member

genlu commented Aug 5, 2021

This is part of the fix for https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1329520
After this, Editor can properly cancel the commit operation if exceed timeout

@genlu genlu merged commit 75a39a2 into dotnet:main Aug 5, 2021
@ghost ghost added this to the Next milestone Aug 5, 2021
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants