Create system for formatting new documents#55432
Closed
davidwengier wants to merge 15 commits intodotnet:mainfrom
Closed
Create system for formatting new documents#55432davidwengier wants to merge 15 commits intodotnet:mainfrom
davidwengier wants to merge 15 commits intodotnet:mainfrom
Conversation
The service simply iterates through a number of providers and calls each one in turn, building up the new document as it goes.
davidwengier
commented
Aug 5, 2021
src/Features/Core/Portable/Formatting/AbstractNewDocumentFormattingService.cs
Outdated
Show resolved
Hide resolved
davidwengier
commented
Aug 5, 2021
src/Features/Core/Portable/Formatting/AbstractNewDocumentFormattingService.cs
Outdated
Show resolved
Hide resolved
...ures/CSharp/Portable/Formatting/CSharpAccessibilityModifiersNewDocumentFormattingProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Formatting/AbstractNewDocumentFormattingService.cs
Show resolved
Hide resolved
src/Features/Core/Portable/Formatting/INewDocumentFormattingProvider.cs
Outdated
Show resolved
Hide resolved
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Overall i think this makes a lot of sense. a bit of oddness in the services/exports, but otherwise this is def a good improvement.
davidwengier
commented
Aug 5, 2021
Member
Author
davidwengier
left a comment
There was a problem hiding this comment.
Stupid github mobile app.. my comments were stuck in comment jail
src/Features/Core/Portable/Formatting/AbstractNewDocumentFormattingService.cs
Outdated
Show resolved
Hide resolved
...ures/CSharp/Portable/Formatting/CSharpAccessibilityModifiersNewDocumentFormattingProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Formatting/AbstractNewDocumentFormattingService.cs
Show resolved
Hide resolved
Contributor
Seems reasonable. Just please comment in the code the intent here. Thanks! |
Member
Author
|
Superseded by #55463 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for #55417
This moves all of the work that the AbstractEditorFactory does on new document creation to various individual providers. Hopefully the layering and MEF stuff is close to correct. It works at least ¯\_(ツ)_/¯
Tests still to come, there is no coverage for the existing system I can see. There might be integration tests, but they should be unchanged anyway.